The Trino project succeeds with your help and contributions. Find details on how to contribute, how maintainers assist, and more related information in the following sections:
This is the process we suggest for contributions. This process is designed to reduce the burden on project reviewers, impact on other contributors, and to keep the amount of rework from the contributor to a minimum.
Sign the contributor license agreement.
Implement the change
[WIP], and share with collaborators.
Create a GitHub pull request (PR).
There are some tests that use external services, like Google BigQuery, and require additional credentials. The Trino project cannot share these credentials with contributors, so it runs these tests in its CI workflows only on branches in the Trino repository, not in contributor forks. Maintainers trigger these test runs for other pull requests as part of their review.
Review is performed by one or more reviewers.
Address concerns and update the pull request.
fixup!commit placed after each commit. This is to make it easier for the reviewer to see what was updated.
Maintainer merges the pull request after final changes are accepted.
Maintainers organize a release to ship the next Trino version with your improvements.
Maintainers support the contributions from the community and other maintainers by participating in the contribution process. The following additional processes and steps apply for their work.
The following aspects apply for reviewing pull requests.
Maintainers can schedule additional workflow runs with tests that use external services when reviewing a PR by adding a comment:
The SHA value should be the full 40 character git SHA of a commit of the feature branch, usually the head commit. This allows runs with the full test suite, including third party integrations and infrastructure for branches that are not in the core repository. Maintainers must review the pull request to understand and assess the security implications of running the test suite on the external service and ensure that no malicious code is run.
The following criteria and aspects apply for merging pull requests.
Reviews and assistance for the contributor on a pull request can proceed as soon as a PR is filed and set as ready for review. A signed CLA is required for merging a PR. Submitted CLAs are managed by the BDFLs.